json-schema icon indicating copy to clipboard operation
json-schema copied to clipboard

Data that looks like a URI but is invalid should be treated as a string

Open iainbeeston opened this issue 8 years ago • 5 comments

There's a bug where if you pass a string as data and it looks like a URI, we try to parse it and load the data from that location. However, if parsing fails, we should give up trying to load remote data and treat the data as a string instead.

iainbeeston avatar Jun 30 '17 13:06 iainbeeston

@RST-J Could I please get a review of this too?

iainbeeston avatar Jul 05 '17 17:07 iainbeeston

Sorry, I'm currently not able to review. I have RL stuff to deal with.

⁣Bis neulich Jonas

Gesendet mit BlueMail ​

Am 5. Juli 2017, 19:36, um 19:36, Iain Beeston [email protected] schrieb:

@RST-J Could I please get a review of this too?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/ruby-json-schema/json-schema/pull/386#issuecomment-313173511

RST-J avatar Jul 06 '17 07:07 RST-J

@RST-J No problem, I understand completely (sorry for spamming you with requests!)

iainbeeston avatar Jul 06 '17 07:07 iainbeeston

This seems like it is still a problem, @bastelfreak could you take a look?

exterm avatar Oct 24 '23 17:10 exterm

There's at least a merge conflict so it needs a rebase.

ekohl avatar Oct 25 '23 16:10 ekohl