facterdb icon indicating copy to clipboard operation
facterdb copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Regenerate Redhat 7 facts

Open zilchms opened this issue 11 months ago • 4 comments

#304 addressed the discrepancy in the IP addresses of redhat 8 (which is important for the unit test failures in puppet-openvpn). However, we missed the RedHat 7 facts which a) have the wrong IPv4 addresses for some reason (introduced in #257, which probably broke more than just openvpn) and b) we are missing all RedHat 7 facts except for version 4.2

zilchms avatar Mar 19 '24 22:03 zilchms

Todo before merge: Re-add legacy facts as puppet 7 isnt EOL yet

zilchms avatar Mar 20 '24 11:03 zilchms

@yakatz sorry to bother you again... do you happen to know how to include the legacy facts when regenerating with 'undle exec rake rhel_alts'?

zilchms avatar Mar 21 '24 23:03 zilchms

The script just takes the centos values and does a find/replace for the target os. Since we actually generate rhel facts, it makes more sense to count the rhel facts as authoritative and replace the other way. I submitted a separate PR for that: https://github.com/voxpupuli/facterdb/pull/303 (Although it assumes rhel 7 support has ended)

yakatz avatar Mar 22 '24 00:03 yakatz

The script also only looks at x86_64, not 386 facts

yakatz avatar Mar 22 '24 00:03 yakatz

@zilchms Can you rebase this?

yakatz avatar May 20 '24 21:05 yakatz

Sure, but I am not sure I finished what I set out to do.

zilchms avatar May 21 '24 05:05 zilchms

discontinued because: https://github.com/voxpupuli/facterdb/pull/354#issuecomment-2132798486

zilchms avatar May 27 '24 11:05 zilchms