facterdb icon indicating copy to clipboard operation
facterdb copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Drop Facter 3 and older factsets

Open bastelfreak opened this issue 1 year ago • 1 comments

Puppet 7 is the oldest supported Puppet version. It vendors Facter 4. The facterdb performance depends on the amount of factsets so it makes sense to get rid of the legacy factsets.

bastelfreak avatar Jan 09 '24 10:01 bastelfreak

My browser was really unhappy trying to open the diff for this PR :-P There are a few places in get_facts.sh where puppet6 is mentioned in a comment. It probably wouldn't hurt to change those to the correct strings.

yakatz avatar Mar 19 '24 13:03 yakatz

I did a rebase. I'm not sure why some of the tests fail :thinking: someone has an idea?

bastelfreak avatar May 14 '24 10:05 bastelfreak

I did a rebase. I'm not sure why some of the tests fail 🤔 someone has an idea?

When I change let(:facter_version) { '4.0.0' } to let(:facter_version) { '4.0.52' } which is the version the facts were generated with, it succeeds.

yakatz avatar May 14 '24 18:05 yakatz

ah lol, yes. Thanks!

bastelfreak avatar May 14 '24 18:05 bastelfreak

IMO this is ready. I ensured that all modern facts are up2date and did a new minor release. I think we can drop the old stuff now.

bastelfreak avatar May 15 '24 19:05 bastelfreak

I'm ok with dropping facter 3. Puppet 7 was released over 3 years ago, puppet 6 is EOL for over a year

TheMeier avatar May 15 '24 19:05 TheMeier