Only install timesync packages if needed
Chrony/NTP is only needed if timesync is requested. In some cases (like containers) it never makes sense.
This was inspired by https://github.com/voxpupuli/beaker-hostgenerator/pull/359#issuecomment-1995159331 and currently testing it out.
Codecov Report
Attention: Patch coverage is 13.33333% with 26 lines in your changes are missing coverage. Please review.
Project coverage is 51.60%. Comparing base (
2a89cfc) to head (e3ec2d5).
:exclamation: Current head e3ec2d5 differs from pull request most recent head c2d1b84. Consider uploading reports for the commit c2d1b84 to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| lib/beaker/platform.rb | 11.53% | 23 Missing :warning: |
| lib/beaker/host_prebuilt_steps.rb | 25.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1853 +/- ##
===========================================
- Coverage 74.62% 51.60% -23.03%
===========================================
Files 81 81
Lines 4492 4498 +6
===========================================
- Hits 3352 2321 -1031
- Misses 1140 2177 +1037
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is still a draft. The fail because the tests don't ensure platform is an instance of Beaker::Platform, unlike the real application. https://github.com/voxpupuli/beaker/pull/1855 is a start for that.
Test changes split off to https://github.com/voxpupuli/beaker/pull/1900.