node-installed-check icon indicating copy to clipboard operation
node-installed-check copied to clipboard

Published 20 hours ago • verified publisher icon voxpelli

Node 22 seems to break the library

Open patricklafrance opened this issue 1 year ago • 6 comments

Hello!

Sorry this is not a super helpful bug report but I wanted to let you know that Node 22 seems to break something with the library. Our ADO CI pipeline is configured to use the latest version of node and installed-check started to act weird as of Wednesday.

With Node 22 we get the following errors, which honestly didn't really made sense to us:

. lint:installed-check: @workleap-mgmt/storybook: @chromatic-com/storybook: Narrower "engines.node" is needed: >=16.0.0
. lint:installed-check: @workleap-mgmt/storybook: @storybook/addon-webpack5-compiler-swc: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/storybook: @storybook/react: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/storybook: @storybook/react-webpack5: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/storybook: @svgr/webpack: Narrower "engines.node" is needed: >=14.0.0
. lint:installed-check: @workleap-mgmt/storybook: react: Narrower "engines.node" is needed: >=0.10.0
. lint:installed-check: @workleap-mgmt/storybook: @pmmmwh/react-refresh-webpack-plugin: Narrower "engines.node" is needed: >=10.13.0
. lint:installed-check: @workleap-mgmt/storybook: @swc/core: Narrower "engines.node" is needed: >=10.0.0
. lint:installed-check: @workleap-mgmt/storybook: browserslist: Narrower "engines.node" is needed: ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || >=13.7.0
. lint:installed-check: @workleap-mgmt/storybook: eslint: Narrower "engines.node" is needed: ^12.22.0 || ^14.17.0 || >=16.0.0
. lint:installed-check: @workleap-mgmt/storybook: postcss: Narrower "engines.node" is needed: ^10.0.0 || ^12.0.0 || >=14.0.0
. lint:installed-check: @workleap-mgmt/storybook: tsconfig-paths-webpack-plugin: Narrower "engines.node" is needed: >=10.13.0
. lint:installed-check: @workleap-mgmt/storybook: typescript: Narrower "engines.node" is needed: >=14.17.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/components: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/federation-runtime: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/http: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/layouts: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/msw: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/shell: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/tracking: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: msw: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: react: Narrower "engines.node" is needed: >=0.10.0
. lint:installed-check: @workleap-mgmt/host-app-sample: react-router-dom: Narrower "engines.node" is needed: >=14.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @svgr/webpack: Narrower "engines.node" is needed: >=14.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @swc/core: Narrower "engines.node" is needed: >=10.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/webpack-configs: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: browserslist: Narrower "engines.node" is needed: ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || >=13.7.0
. lint:installed-check: @workleap-mgmt/host-app-sample: eslint: Narrower "engines.node" is needed: ^12.22.0 || ^14.17.0 || >=16.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: http-server: Narrower "engines.node" is needed: >=12.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: nodemon: Narrower "engines.node" is needed: >=10.0.0
. lint:installed-check: @workleap-mgmt/host-app-sample: stylelint: Narrower "engines.node" is needed: >=18.12.0
. lint:installed-check: @workleap-mgmt/host-app-sample: typescript: Narrower "engines.node" is needed: >=14.17.0
. lint:installed-check: @workleap-mgmt/host-app-sample: webpack: Narrower "engines.node" is needed: >=10.13.0
. lint:installed-check: @workleap-mgmt/host-app-sample: webpack-cli: Narrower "engines.node" is needed: >=14.15.0
. lint:installed-check: @workleap-mgmt/host-app-sample: webpack-dev-server: Narrower "engines.node" is needed: >=18.12.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/components: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/federation-runtime: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/http: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/layouts: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/msw: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/shell: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: msw: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: react: Narrower "engines.node" is needed: >=0.10.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: react-router-dom: Narrower "engines.node" is needed: >=14.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @svgr/webpack: Narrower "engines.node" is needed: >=14.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @swc/core: Narrower "engines.node" is needed: >=10.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/eslint-plugin: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/webpack-configs: Narrower "engines.node" is needed: >=18.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: browserslist: Narrower "engines.node" is needed: ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || >=13.7.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: cross-env: Narrower "engines.node" is needed: >=10.14.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: eslint: Narrower "engines.node" is needed: ^12.22.0 || ^14.17.0 || >=16.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: http-server: Narrower "engines.node" is needed: >=12.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: nodemon: Narrower "engines.node" is needed: >=10.0.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: stylelint: Narrower "engines.node" is needed: >=18.12.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: typescript: Narrower "engines.node" is needed: >=14.17.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: webpack: Narrower "engines.node" is needed: >=10.13.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: webpack-cli: Narrower "engines.node" is needed: >=14.15.0
. lint:installed-check: @workleap-mgmt/remote-module-sample: webpack-dev-server: Narrower "engines.node" is needed: >=18.12.0
. lint:installed-check: @workleap-mgmt/components: @react-types/button: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
. lint:installed-check: @workleap-mgmt/components: @react-types/shared: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
. lint:installed-check: @workleap-mgmt/components: @storybook/react: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
. lint:installed-check: @workleap-mgmt/components: @storybook/react: Narrower "peerDependencies.react-dom" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
. lint:installed-check: @workleap-mgmt/eslint-plugin: tsup: Narrower "peerDependencies.typescript" is needed: >=4.5.0
. lint:installed-check: @workleap-mgmt/federation-runtime: @squide/firefly: Narrower "engines.node" is needed: >=20.0.0
. lint:installed-check: @workleap-mgmt/layouts: @workleap-nav/react: Narrower "peerDependencies.react" is needed: >=16.8.0
. lint:installed-check: @workleap-mgmt/layouts: @storybook/react: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
. lint:installed-check: @workleap-mgmt/layouts: @workleap-nav/react: Narrower "peerDependencies.react-dom" is needed: >=16.8.0
. lint:installed-check: @workleap-mgmt/layouts: @storybook/react: Narrower "peerDependencies.react-dom" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
. lint:installed-check: @workleap-mgmt/shell: @react-aria/toast: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
. lint:installed-check: @workleap-mgmt/shell: @react-stately/toast: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
. lint:installed-check: @workleap-mgmt/shell: @workleap-nav/react: Narrower "peerDependencies.react" is needed: >=16.8.0
. lint:installed-check: @workleap-mgmt/shell: @storybook/react: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
. lint:installed-check: @workleap-mgmt/shell: @workleap-nav/react: Narrower "peerDependencies.react-dom" is needed: >=16.8.0
. lint:installed-check: @workleap-mgmt/shell: @storybook/react: Narrower "peerDependencies.react-dom" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
. lint:installed-check: @workleap-mgmt/webpack-configs: @squide/firefly-configs: Narrower "engines.node" is needed: >=20.0.0
. lint:installed-check: @workleap-mgmt/webpack-configs: tsup: Narrower "peerDependencies.@swc/core" is needed: ^1.0.0
. lint:installed-check: @workleap-mgmt/webpack-configs: tsup: Narrower "peerDependencies.postcss" is needed: ^8.4.12

Once we forced the pipeline to use Node 21, they all went away:

. lint:installed-check$ installed-check
. lint:installed-check: Done

Once of the reason why I am saying that these errors seems suspicious to us is that it's reporting "engines.node" version error for packages that do not define a node engine version.

Hope this help!

Patrick

patricklafrance avatar Apr 26 '24 20:04 patricklafrance

Thanks! I'll investigate 🙏

I would also suggest setting your GH Actions to use lts/* as their version, that way you will not be caught out right away on new release (as Node 22 will not become LTS for another six months)

voxpelli avatar Apr 27 '24 07:04 voxpelli

@patricklafrance Are you sure this isn't caused by a combination of the new workspace support in installed-check as well as the new peer dependency checks?

I added node 22 to ci and it passes in ci here.

Can you install version 9.3.0 of this module locally and check if it gives the same output then?

I can also suggest the new --fix command that was added in 9.3.0 to help adapt all package.json files with the suggestions

voxpelli avatar May 07 '24 12:05 voxpelli

Hey @voxpelli!

So I tried with version 9.3.0 locally and on the CI with Node v22.

Locally, everything works fine.

On our CI thought I still get the same error. If I downgrade to Node v21, the error still goes away.

Image: ubuntu-latest

Aquiring Node called
Retry count on download fails: 5 Retry delay: 1000ms
Downloading: https://nodejs.org/dist/v22.1.0/node-v22.1.0-linux-x64.tar.gz
Extracting archive
/usr/bin/tar xC /home/vsts/work/_temp/7c1f77fa-161c-415c-8c34-033fbcf4eb40 -f /home/vsts/work/_temp/9eb49d4a-353b-4c0a-bda3-33cb56006ac0

Caching tool: node 22.1.0 x64
Prepending PATH environment variable with directory: /opt/hostedtoolcache/node/22.1.0/x64/bin

/usr/bin/bash --noprofile --norc /home/vsts/work/_temp/b810eab0-1f58-4379-9554-025bc07a0f6e.sh
Preparing pnpm@latest-9 for immediate activation...
! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing [email protected]+sha512.67f5879916a9293e5cf059c23853d571beaf4f753c707f40cb22bed5fb1578c6aad3b6c4107ccb3ba0b35be003eb621a16471ac836c87beb53f9d54bb4612724.
! For more details about this field, consult the documentation at https://nodejs.org/api/packages.html#packagemanager

2024-05-08T01:35:26.1351166Z . lint:installed-check$ installed-check
2024-05-08T01:35:27.2748163Z . lint:stylelint: (node:2233) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
2024-05-08T01:35:27.2762205Z . lint:stylelint: (Use `node --trace-deprecation ...` to show where the warning was created)
2024-05-08T01:35:28.5052992Z . lint:installed-check: [41m[30mErrors:[39m[49m
2024-05-08T01:35:28.5054023Z . lint:installed-check: @workleap-mgmt/storybook: @chromatic-com/storybook: Narrower "engines.node" is needed: >=16.0.0
2024-05-08T01:35:28.5055010Z . lint:installed-check: @workleap-mgmt/storybook: @storybook/addon-webpack5-compiler-swc: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5055899Z . lint:installed-check: @workleap-mgmt/storybook: @storybook/react: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5069525Z . lint:installed-check: @workleap-mgmt/storybook: @storybook/react-webpack5: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5079216Z . lint:installed-check: @workleap-mgmt/storybook: @svgr/webpack: Narrower "engines.node" is needed: >=14.0.0
2024-05-08T01:35:28.5088688Z . lint:installed-check: @workleap-mgmt/storybook: react: Narrower "engines.node" is needed: >=0.10.0
2024-05-08T01:35:28.5097776Z . lint:installed-check: @workleap-mgmt/storybook: @pmmmwh/react-refresh-webpack-plugin: Narrower "engines.node" is needed: >=10.13.0
2024-05-08T01:35:28.5106082Z . lint:installed-check: @workleap-mgmt/storybook: @swc/core: Narrower "engines.node" is needed: >=10.0.0
2024-05-08T01:35:28.5118193Z . lint:installed-check: @workleap-mgmt/storybook: browserslist: Narrower "engines.node" is needed: ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || >=13.7.0
2024-05-08T01:35:28.5124772Z . lint:installed-check: @workleap-mgmt/storybook: eslint: Narrower "engines.node" is needed: ^12.22.0 || ^14.17.0 || >=16.0.0
2024-05-08T01:35:28.5131328Z . lint:installed-check: @workleap-mgmt/storybook: postcss: Narrower "engines.node" is needed: ^10.0.0 || ^12.0.0 || >=14.0.0
2024-05-08T01:35:28.5138537Z . lint:installed-check: @workleap-mgmt/storybook: tsconfig-paths-webpack-plugin: Narrower "engines.node" is needed: >=10.13.0
2024-05-08T01:35:28.5146533Z . lint:installed-check: @workleap-mgmt/storybook: typescript: Narrower "engines.node" is needed: >=14.17.0
2024-05-08T01:35:28.5153981Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/components: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5162373Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/federation-runtime: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5169838Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/http: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5177378Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/layouts: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5190549Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/msw: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5197369Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/shell: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5260748Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/tracking: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5269305Z . lint:installed-check: @workleap-mgmt/host-app-sample: msw: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5277138Z . lint:installed-check: @workleap-mgmt/host-app-sample: react: Narrower "engines.node" is needed: >=0.10.0
2024-05-08T01:35:28.5284231Z . lint:installed-check: @workleap-mgmt/host-app-sample: react-router-dom: Narrower "engines.node" is needed: >=14.0.0
2024-05-08T01:35:28.5334777Z . lint:installed-check: @workleap-mgmt/host-app-sample: @svgr/webpack: Narrower "engines.node" is needed: >=14.0.0
2024-05-08T01:35:28.5342747Z . lint:installed-check: @workleap-mgmt/host-app-sample: @swc/core: Narrower "engines.node" is needed: >=10.0.0
2024-05-08T01:35:28.5350196Z . lint:installed-check: @workleap-mgmt/host-app-sample: @workleap-mgmt/webpack-configs: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5395070Z . lint:installed-check: @workleap-mgmt/host-app-sample: browserslist: Narrower "engines.node" is needed: ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || >=13.7.0
2024-05-08T01:35:28.5401760Z . lint:installed-check: @workleap-mgmt/host-app-sample: eslint: Narrower "engines.node" is needed: ^12.22.0 || ^14.17.0 || >=16.0.0
2024-05-08T01:35:28.5407830Z . lint:installed-check: @workleap-mgmt/host-app-sample: http-server: Narrower "engines.node" is needed: >=12.0.0
2024-05-08T01:35:28.5421209Z . lint:installed-check: @workleap-mgmt/host-app-sample: nodemon: Narrower "engines.node" is needed: >=10.0.0
2024-05-08T01:35:28.5428380Z . lint:installed-check: @workleap-mgmt/host-app-sample: stylelint: Narrower "engines.node" is needed: >=18.12.0
2024-05-08T01:35:28.5436228Z . lint:installed-check: @workleap-mgmt/host-app-sample: typescript: Narrower "engines.node" is needed: >=14.17.0
2024-05-08T01:35:28.5442203Z . lint:installed-check: @workleap-mgmt/host-app-sample: webpack: Narrower "engines.node" is needed: >=10.13.0
2024-05-08T01:35:28.5448913Z . lint:installed-check: @workleap-mgmt/host-app-sample: webpack-cli: Narrower "engines.node" is needed: >=14.15.0
2024-05-08T01:35:28.5456101Z . lint:installed-check: @workleap-mgmt/host-app-sample: webpack-dev-server: Narrower "engines.node" is needed: >=18.12.0
2024-05-08T01:35:28.5462424Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/components: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5469791Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/federation-runtime: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5476337Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/http: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5482214Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/layouts: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5487826Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/msw: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5493754Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/shell: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5501080Z . lint:installed-check: @workleap-mgmt/remote-module-sample: msw: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5553803Z . lint:installed-check: @workleap-mgmt/remote-module-sample: react: Narrower "engines.node" is needed: >=0.10.0
2024-05-08T01:35:28.5559933Z . lint:installed-check: @workleap-mgmt/remote-module-sample: react-router-dom: Narrower "engines.node" is needed: >=14.0.0
2024-05-08T01:35:28.5565343Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @svgr/webpack: Narrower "engines.node" is needed: >=14.0.0
2024-05-08T01:35:28.5571003Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @swc/core: Narrower "engines.node" is needed: >=10.0.0
2024-05-08T01:35:28.5576656Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/eslint-plugin: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5582917Z . lint:installed-check: @workleap-mgmt/remote-module-sample: @workleap-mgmt/webpack-configs: Narrower "engines.node" is needed: >=18.0.0
2024-05-08T01:35:28.5588473Z . lint:installed-check: @workleap-mgmt/remote-module-sample: browserslist: Narrower "engines.node" is needed: ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || >=13.7.0
2024-05-08T01:35:28.5593801Z . lint:installed-check: @workleap-mgmt/remote-module-sample: cross-env: Narrower "engines.node" is needed: >=10.14.0
2024-05-08T01:35:28.5599471Z . lint:installed-check: @workleap-mgmt/remote-module-sample: eslint: Narrower "engines.node" is needed: ^12.22.0 || ^14.17.0 || >=16.0.0
2024-05-08T01:35:28.5605922Z . lint:installed-check: @workleap-mgmt/remote-module-sample: http-server: Narrower "engines.node" is needed: >=12.0.0
2024-05-08T01:35:28.5615257Z . lint:installed-check: @workleap-mgmt/remote-module-sample: nodemon: Narrower "engines.node" is needed: >=10.0.0
2024-05-08T01:35:28.5621858Z . lint:installed-check: @workleap-mgmt/remote-module-sample: stylelint: Narrower "engines.node" is needed: >=18.12.0
2024-05-08T01:35:28.5635483Z . lint:installed-check: @workleap-mgmt/remote-module-sample: typescript: Narrower "engines.node" is needed: >=14.17.0
2024-05-08T01:35:28.5643798Z . lint:installed-check: @workleap-mgmt/remote-module-sample: webpack: Narrower "engines.node" is needed: >=10.13.0
2024-05-08T01:35:28.5653246Z . lint:installed-check: @workleap-mgmt/remote-module-sample: webpack-cli: Narrower "engines.node" is needed: >=14.15.0
2024-05-08T01:35:28.5660303Z . lint:installed-check: @workleap-mgmt/remote-module-sample: webpack-dev-server: Narrower "engines.node" is needed: >=18.12.0
2024-05-08T01:35:28.5666865Z . lint:installed-check: @workleap-mgmt/components: @react-types/button: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
2024-05-08T01:35:28.5674069Z . lint:installed-check: @workleap-mgmt/components: @react-types/shared: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
2024-05-08T01:35:28.5679760Z . lint:installed-check: @workleap-mgmt/components: @storybook/react: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5685939Z . lint:installed-check: @workleap-mgmt/components: @storybook/react: Narrower "peerDependencies.react-dom" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5691740Z . lint:installed-check: @workleap-mgmt/eslint-plugin: tsup: Narrower "peerDependencies.typescript" is needed: >=4.5.0
2024-05-08T01:35:28.5697537Z . lint:installed-check: @workleap-mgmt/federation-runtime: @squide/firefly: Narrower "engines.node" is needed: >=20.0.0
2024-05-08T01:35:28.5703471Z . lint:installed-check: @workleap-mgmt/federation-runtime: @squide/i18next: Narrower "engines.node" is needed: >=20.0.0
2024-05-08T01:35:28.5712031Z . lint:installed-check: @workleap-mgmt/layouts: @workleap-nav/react: Narrower "peerDependencies.react" is needed: >=16.8.0
2024-05-08T01:35:28.5792543Z . lint:installed-check: @workleap-mgmt/layouts: @storybook/react: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5799191Z . lint:installed-check: @workleap-mgmt/layouts: @workleap-nav/react: Narrower "peerDependencies.react-dom" is needed: >=16.8.0
2024-05-08T01:35:28.5805630Z . lint:installed-check: @workleap-mgmt/layouts: @storybook/react: Narrower "peerDependencies.react-dom" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5811743Z . lint:installed-check: @workleap-mgmt/msw: @squide/fakes: Narrower "engines.node" is needed: >=20.0.0
2024-05-08T01:35:28.5819472Z . lint:installed-check: @workleap-mgmt/shell: @react-aria/toast: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
2024-05-08T01:35:28.5825719Z . lint:installed-check: @workleap-mgmt/shell: @react-stately/toast: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0-rc.1 || ^18.0.0
2024-05-08T01:35:28.5831595Z . lint:installed-check: @workleap-mgmt/shell: @workleap-nav/react: Narrower "peerDependencies.react" is needed: >=16.8.0
2024-05-08T01:35:28.5837431Z . lint:installed-check: @workleap-mgmt/shell: @storybook/react: Narrower "peerDependencies.react" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5843025Z . lint:installed-check: @workleap-mgmt/shell: @workleap-nav/react: Narrower "peerDependencies.react-dom" is needed: >=16.8.0
2024-05-08T01:35:28.5848955Z . lint:installed-check: @workleap-mgmt/shell: @storybook/react: Narrower "peerDependencies.react-dom" is needed: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5855446Z . lint:installed-check: @workleap-mgmt/webpack-configs: @squide/firefly-webpack-configs: Narrower "engines.node" is needed: >=20.0.0
2024-05-08T01:35:28.5862102Z . lint:installed-check: @workleap-mgmt/webpack-configs: tsup: Narrower "peerDependencies.@swc/core" is needed: ^1.0.0
2024-05-08T01:35:28.5867838Z . lint:installed-check: @workleap-mgmt/webpack-configs: tsup: Narrower "peerDependencies.postcss" is needed: ^8.4.12
2024-05-08T01:35:28.5881408Z . lint:installed-check: [106m[30mSuggestions:[39m[49m
2024-05-08T01:35:28.5887976Z . lint:installed-check: @workleap-mgmt/storybook: Combined "engines.node" needs to be narrower: >=18.0.0
2024-05-08T01:35:28.5894277Z . lint:installed-check: @workleap-mgmt/host-app-sample: Combined "engines.node" needs to be narrower: >=18.12.0
2024-05-08T01:35:28.5935782Z . lint:installed-check: @workleap-mgmt/remote-module-sample: Combined "engines.node" needs to be narrower: >=18.12.0
2024-05-08T01:35:28.5942029Z . lint:installed-check: @workleap-mgmt/components: Combined "peerDependencies.react" needs to be narrower: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5948477Z . lint:installed-check: @workleap-mgmt/components: Combined "peerDependencies.react-dom" needs to be narrower: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5955222Z . lint:installed-check: @workleap-mgmt/eslint-plugin: Combined "peerDependencies.typescript" needs to be narrower: >=4.5.0
2024-05-08T01:35:28.5960860Z . lint:installed-check: @workleap-mgmt/federation-runtime: Combined "engines.node" needs to be narrower: >=20.0.0
2024-05-08T01:35:28.5967088Z . lint:installed-check: @workleap-mgmt/layouts: Combined "peerDependencies.react" needs to be narrower: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5973937Z . lint:installed-check: @workleap-mgmt/layouts: Combined "peerDependencies.react-dom" needs to be narrower: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5979779Z . lint:installed-check: @workleap-mgmt/msw: Combined "engines.node" needs to be narrower: >=20.0.0
2024-05-08T01:35:28.5986060Z . lint:installed-check: @workleap-mgmt/shell: Combined "peerDependencies.react" needs to be narrower: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5991934Z . lint:installed-check: @workleap-mgmt/shell: Combined "peerDependencies.react-dom" needs to be narrower: ^16.8.0 || ^17.0.0 || ^18.0.0
2024-05-08T01:35:28.5997928Z . lint:installed-check: @workleap-mgmt/webpack-configs: Combined "engines.node" needs to be narrower: >=20.0.0
2024-05-08T01:35:28.6003641Z . lint:installed-check: @workleap-mgmt/webpack-configs: Combined "peerDependencies.@swc/core" needs to be narrower: ^1.0.0
2024-05-08T01:35:28.6013934Z . lint:installed-check: @workleap-mgmt/webpack-configs: Combined "peerDependencies.postcss" needs to be narrower: ^8.4.12
2024-05-08T01:35:28.6051759Z . lint:installed-check: Failed

patricklafrance avatar May 08 '24 01:05 patricklafrance

Are the “errors” that installed-check points out here valid or invalid errors?

Hard to know whether the error is in the old case or in the new version – it’s evidently inconsistent, but if the “errors” pointed out in node 22 are valid, then the actual problem is why they don’t appear for you elsewhere as well

I see that you are using pnpm and workspaces? Are you using the same version of pnpm in both places?

voxpelli avatar May 08 '24 11:05 voxpelli

I wonder if it’s similar to #97, which also complains of new “errors”

voxpelli avatar May 08 '24 11:05 voxpelli

Indeed, at first I thought the errors were not valid but after dealing with https://github.com/voxpelli/node-installed-check/issues/97 and look back at the errors, it seems like the errors are legit and are related to installed-check now detecting the workspaces.

patricklafrance avatar May 09 '24 00:05 patricklafrance