node-connect-pg-simple icon indicating copy to clipboard operation
node-connect-pg-simple copied to clipboard

Published 20 hours ago • verified publisher icon voxpelli

Change `pg` to a peer dependency

Open thernstig opened this issue 2 years ago • 1 comments

Currenly pg is configured as a dependency of this project:

https://github.com/voxpelli/node-connect-pg-simple/blob/fdfcda883f0f730a3ee8e56d6e2d717e442d2f7d/package.json#L16-L19

Would it not be more correct to install this as a peerDependency? With npm 7 peer dependencies are also installed by default.

thernstig avatar Jan 24 '22 15:01 thernstig

I don't think it would add much to do that change and its not strictly more correct. Only slight benefit would be to be able to indicate unsupported versions of pg 🤔

I'll think about it + lets other weigh in on it.

voxpelli avatar May 24 '22 09:05 voxpelli

I currently see no need for this change and no one else has weighed in over a year.

I'm still open to having a discussion of some feel strongly about this in either direction.

voxpelli avatar Jun 07 '23 16:06 voxpelli