Pelle Wessman

pnpm [encourages to use it](https://pnpm.io/package_json#engines) to also specify the `pnpm` version range and behaves the same as npm regarding `engines.node`: > Unless the user has set the engine-strict config flag...

@jsumners My latest comments were in response to https://github.com/fastify/fastify/pull/5667#issuecomment-2435329330 --- But since you bring it up: Your quote and your previous reply seems to suggest that you are the opposite...

> Surely you meant implicitly, right? Not setting an optional field that's not enforced anywhere cannot have an explicit meaning I think Since there is no reference spec for `package.json`...

> > If the team decides that the field should be maintained, then it should be maintained across the whole org. > > I'm against adding more self-induced churn on...

`^20 || ^22` would imply that Node 23 is explicitly unsupported? Like with every peer dependency it’s the best to keep the upper limit open and accept new versions until...

Engines is meant to convey _compatibility_ not active support. A deprecated module isn’t given a last update that sets the engine to `0` or something to indicate that it’s not...

I kind of object to the phrasing of this issue title. It does not cause an ESLint error. It fails the `default` rule from `eslint-plugin-import-x` (which coincidentally is a fork...

From the description of the [`import-x/default`](https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/default.md#when-not-to-use-it) rule (same for [`import/default`](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/default.md#when-not-to-use-it)): > This rule currently does not interpret `module.exports = ...` as a `default` export, either, so such a situation will...

Inspecting the types now, its partly right: For some reason only this line is generated and exported: https://github.com/jsx-eslint/eslint-plugin-react/blob/ae6fb8da7d1853c5c2339db525af7d678edb216d/index.js#L91 Not everything from https://github.com/jsx-eslint/eslint-plugin-react/blob/ae6fb8da7d1853c5c2339db525af7d678edb216d/index.js#L30

Replacing the `index.js` with something like this makes the types generated be more proper: ```js module.exports = Object.assign(plugin, { configs: Object.assign(plugin.configs, { flat, }), }); ``` I'm not able to...