Pelle Wessman comments

Results 795 comments of


                                            Pelle Wessman

How does this interact with Error causes?

@staltz Good input! I have made an issue about adding that to `stackWithCauses()` 👍 https://github.com/voxpelli/pony-cause/issues/22

How does this interact with Error causes?

@staltz `ErrorWithCause` is meant to be a drop in replacement for the standardised `new Error('foo', { cause: err })`, to be used in contexts where the built in one isn't...

How does this interact with Error causes?

Here's a screenshot of how Node 16.14.0 `console.log` handles it:

How does this interact with Error causes?

Eg. `pino` has got support merged as well: https://github.com/pinojs/pino-std-serializers/pull/78

How does this interact with Error causes?

@staltz That sounds like a good approach to it, I’ll try to make it happen soon 👍

How does this interact with Error causes?

@staltz What's your thoughts on this solution? https://github.com/voxpelli/pony-cause/pull/23

http: Add noDelay to http.request() options.

@sam-github @richardlau I have posted a new PR that replaces the closed #906 and again pushes for changing the default behavior to be `TCP_NODELAY`: https://github.com/nodejs/node/issues/34185

http: Add noDelay to http.request() options.

> > Do you have an idea of an adequate test plan? > > I would just override the `setNoDelay` method. So basically: Override the `setNoDelay` method in two tests...

http: Add noDelay to http.request() options.

@rustyconover Feels like the tests should be fairly quick to wrap up, need some help or you have time to fix them yourself?

http: Add noDelay to http.request() options.

This isn't a breaking change, right? So it can go out in any minor? So not important to eg. get it into https://github.com/nodejs/node/pull/40119 ?