fiftyone icon indicating copy to clipboard operation
fiftyone copied to clipboard

Transformers GPU Support

Open danielgural opened this issue 1 year ago • 1 comments

What changes are proposed in this pull request?

Adding GPU support to transformers utils

How is this patch tested? If it is not, please explain why.

Run this notebook tutorial with gpu https://docs.voxel51.com/integrations/huggingface.html#batch-inference

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • [ ] No. You can skip the rest of this section.
  • [ ] Yes. Give a description of this change to be included in the release notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • [ ] App: FiftyOne application changes
  • [ ] Build: Build and test infrastructure changes
  • [ ] Core: Core fiftyone Python library changes
  • [ ] Documentation: FiftyOne documentation changes
  • [ ] Other

Summary by CodeRabbit

  • New Features

    • Improved device management for model and processor allocation, ensuring models load on the appropriate device (CUDA or CPU) seamlessly.
  • Bug Fixes

    • Streamlined logic for device assignment during model loading, enhancing consistency across different transformer classes.

danielgural avatar Oct 24 '24 19:10 danielgural

Walkthrough

The changes primarily involve modifications to device allocation handling for models and processors in the fiftyone/utils/transformers.py file. The device determination logic has been simplified to utilize torch.cuda.is_available(), ensuring models and processors are assigned to "cuda" if available, or defaulting to "cpu". The _load_model methods across various transformer classes have been updated to explicitly move models to the appropriate device upon loading, enhancing consistency in device management.

Changes

File Path Change Summary
fiftyone/utils/transformers.py - Updated device allocation logic in FiftyOneTransformer, FiftyOneZeroShotTransformer, and other transformer classes to use torch.cuda.is_available().
- Modified _load_model methods to ensure models and processors are moved to the designated device upon loading.
- Adjusted _get_detector_from_processor and _get_model_for_image_text_retrieval functions for direct model loading on specified device.

Possibly related PRs

  • #4587: The changes in this PR also focus on device management for the FiftyOneTransformer class, specifically enhancing the handling of device allocation for tensor operations, which aligns closely with the modifications made in the main PR regarding device assignment logic.

Suggested reviewers

  • jacobmarks

🐰 In the land of code, where models reside,
A hop for the device, we take in our stride.
With CUDA now checked, and tensors in place,
Our transformers are ready, they quicken their pace.
So let’s load them with care, on devices they’ll thrive,
In the world of FiftyOne, our models come alive! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 24 '24 19:10 coderabbitai[bot]