fix adaptive menu hidden items

[kaixi-wang]

What changes are proposed in this pull request?

Fix error from lastVisibleItem not existing:

Also handle duplicate ids in the indexing that can cause the buttons rendered to not match the number of items... not sure how this happens though and it prob should be handled earlier

How is this patch tested? If it is not, please explain why.

• run locally

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• [ ] No. You can skip the rest of this section.
• [ ] Yes. Give a description of this change to be included in the release notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

• [ ] App: FiftyOne application changes
• [ ] Build: Build and test infrastructure changes
• [ ] Core: Core fiftyone Python library changes
• [ ] Documentation: FiftyOne documentation changes
• [ ] Other

Summary by CodeRabbit

• New Features

  • Enhanced the AdaptiveMenu component to handle duplicate item IDs, ensuring uniqueness and preventing errors.
  • Improved logic for item movement based on priority, refining user interactions.
  • Updated visibility calculations for menu items to enhance user experience.

• Bug Fixes

  • Resolved potential issues with item visibility and movement logic.

[coderabbitai[bot]]

Walkthrough

The changes in the AdaptiveMenu component involve enhancements to handle duplicate item IDs, updates to the visibility calculation logic, and refinements in the item movement conditions. Specifically, the logic now logs an error for duplicate IDs and modifies them for uniqueness. The visibility calculation checks for valid indices, defaulting to zero when necessary. Additionally, item movement is conditioned on the priority property, improving the robustness of the component.

Changes

File Path

Change Summary

app/packages/components/src/components/AdaptiveMenu/index.tsx

- Added logic to handle duplicate item IDs in the items array, logging errors and modifying IDs for uniqueness. - Updated computedHidden calculation in autoFitNodes to check for valid indices. - Modified onMove function to check priority property for dragged items. - Updated type definitions for AdaptiveMenuItemPropsType, AdaptiveMenuPropsType, and MoreItemsPropsType to reflect changes in item handling.

Suggested reviewers

• ritch

🐰 In the menu where items play,
Unique IDs save the day!
With checks for moves and hidden sights,
Our component hops to new heights!
Errors logged, no duplicates found,
A robust menu, joy abound! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[benjaminpkane]

There are conflicts now. @sashankaryal you already resolved this issue, correct?

[sashankaryal]

There are conflicts now. @sashankaryal you already resolved this issue, correct?

Yes, already fixed. Closing this PR. Thanks Kacey for the PR.