vouch-proxy icon indicating copy to clipboard operation
vouch-proxy copied to clipboard

Published 20 hours ago • verified publisher icon vouch

Provide compiled binaries

Open Nyoroon opened this issue 5 years ago • 12 comments

Hello!

It would be very useful to have pre-compiled binaries for those who deploy it on bare-metal and VM. Maybe build it with travis and push to github releases?

Nyoroon avatar Apr 17 '19 13:04 Nyoroon

Thanks for the suggestion. Its a good idea.

To offer a static binary as a release we'd need to include the additional static files which get served by the webapp.

The go generate method outlined here seems like a viable path.. https://stackoverflow.com/questions/17796043/how-to-embed-files-into-golang-binaries

And of course storing the MD5 checksum

@halkeye setup travis for Vouch Proxy so he may have some thoughts as well.

@Nyoroon is this something you'd care to work on?

bnfinet avatar Apr 17 '19 16:04 bnfinet

Maybe just pack static files in same .tar.gz/.zip/whatever? That's gonna be enough for configuration management systems.

rlex avatar May 26 '20 23:05 rlex

I don't remember this issue at all. Go releaser is pretty good for uploading files to the releases tab, but yea the static templates that are external certainly make things more complicated

Goreleaser should be able to do it

halkeye avatar May 26 '20 23:05 halkeye

Definitely will be better than just source and docker images, i think.

Plus might be easier to customize. Looking at git history, templates are pretty stable and rarely changed?

rlex avatar May 27 '20 00:05 rlex

This action may be the mechanism to publish the binaries with each release. Still need to bundle the other files. https://github.com/skx/github-action-publish-binaries

bnfinet avatar Jun 09 '20 18:06 bnfinet

@bnfinet You potentially could distribute the static assets separately and require the administrator to define the location to those assets?

i.e. vouch-proxy -static.path=/opt/vouch-proxy/static/ or similar

hbjydev avatar May 18 '22 12:05 hbjydev

@hbjydev this issue is showing it's age. As of v0.29.0 all static assets are embedded in the binary.. https://github.com/vouch/vouch-proxy/blob/master/CHANGELOG.md#v0290

bnfinet avatar May 18 '22 16:05 bnfinet

@hbjydev this issue is showing it's age. As of v0.29.0 all static assets are embedded in the binary..

https://github.com/vouch/vouch-proxy/blob/master/CHANGELOG.md#v0290

Ah, sorry about that. I was looking at bare metal installation stuff and stumbled on this randomly so I didn't see the changelog

hbjydev avatar May 18 '22 16:05 hbjydev

@hbjydev this issue is showing it's age. As of v0.29.0 all static assets are embedded in the binary.. https://github.com/vouch/vouch-proxy/blob/master/CHANGELOG.md#v0290

So now it is possible to publish binaries with each release, right? Any plans on implementing?

nuclon avatar Oct 04 '23 06:10 nuclon

@bnfinet is the only one that can do releases, ~and he hasn't been online in a while,no activity in github, twitter hasn't been updated since 2020, and website is now gone. My guess is something happened.~ Nm, I see a comment from him a few months ago :)

I would recommend if you want the feature implemented, you fork and do it. Maybe @aaronpk (as a member of core) might have merging and releasing rights. But i'd still think project needs to find a new home.

halkeye avatar Oct 04 '23 16:10 halkeye

:) yeah I'm around, I'm just extremely choosey at the moment

Sorry for some cobwebs here. I do expect to get back to VP once it starts raining in earnest. Until then I have to prioritize other life goals.

bnfinet avatar Oct 04 '23 16:10 bnfinet

Looks like this could be automated fairly simply with GitHub Actions: https://dev.to/koddr/github-action-for-release-your-go-projects-as-fast-and-easily-as-possible-20a2

Would you be interested in a PR implementing this @bnfinet?

fukawi2 avatar Oct 30 '23 03:10 fukawi2