thruway.js icon indicating copy to clipboard operation
thruway.js copied to clipboard

Angular 8 compability: rxjs 6.5.3

Open andzejsw opened this issue 6 years ago • 4 comments

When i tried to upgrade my angular app from version 7.x to version 8.x, this error occured: Package "thruway.js" has an incompatible peer dependency to "rxjs" (requires "^5.5.12", would install "6.5.3").

andzejsw avatar Oct 25 '19 13:10 andzejsw

After i manualy installed 'rxjs' version 6.5.3, i was able to upgrade angular to version 8.2.12, but when i tried to open my app, there was this error, related to thruway.js:

TypeError: Class constructor Subject cannot be invoked without 'new'
    at new WebSocketTransport (WebSocketTransport.js:29)
    at new Client (Client.js:90)

andzejsw avatar Oct 28 '19 09:10 andzejsw

Angular 8 defaults to es2015. In tsconfig, can you try changing target to es5?

If that works, I'll look into updating the lib for es2015.

davidwdan avatar Oct 28 '19 13:10 davidwdan

Angular 8 defaults to es2015. In tsconfig, can you try changing target to es5?

If that works, I'll look into updating the lib for es2015.

Sorry for long waiting. Yes, it works with es5. Tnx. Please let us know, when there will be es2015 support available. And again, big thanks!

andzejsw avatar Nov 06 '19 08:11 andzejsw

+1 for es2015 support

Martin-4Spaces avatar Nov 25 '19 14:11 Martin-4Spaces