libmdbx-rs icon indicating copy to clipboard operation
libmdbx-rs copied to clipboard

Optionally de-vendor libmdbx

Open SamWilsn opened this issue 1 year ago • 1 comments

When packaging for Linux distributions (in my case, Gentoo), it's generally the policy to link against the system-wide installed versions of a library rather than bundling it. The pattern I've used in this PR is similar to what's used by openssl-sys and other crates.

SamWilsn avatar Aug 08 '24 14:08 SamWilsn

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 08 '24 14:08 CLAassistant

May I ask why you've chosen to close this?

SamWilsn avatar Jan 02 '25 15:01 SamWilsn

a) You've not signed the CLA. b) Wrapping a different version of libmdbx than the one vendored is something to be avoided. The only way to ensure this is having libmdbx vendored.

vorot93 avatar Jan 08 '25 21:01 vorot93

I'll sign the CLA if it's required to get this merged, but there's no point if you won't accept the patch.

If the dependency on mdbx is really that strict, I can specify an exact version in the packaging script. The only people who use this feature will be distro maintainers, and hopefully they can be expected to understand its impact.

SamWilsn avatar Jan 08 '25 22:01 SamWilsn