tokio-jsonrpc icon indicating copy to clipboard operation
tokio-jsonrpc copied to clipboard

Upgrade to current Tokio

Open 0xpr03 opened this issue 7 years ago • 2 comments

This crate still uses tokio-core which is not in use anymore for current tokio applications. Upgrading this to the current tokio crate library would allow it to work with other current tokio applications.

I've had to use another crate because of this, as I can't chain this with other tokio systems currently.

0xpr03 avatar Oct 28 '18 21:10 0xpr03

Hello.

I understand the problem. However, for „proper“ tokio migration, it should modified so all the futures in there are actually Send (this isn't the case, but mostly because there are Rcs that should be changed into Arcs and unsync mpsc instead of sync ones).

Anyway, this is some amount of work and I don't really have much motivation to work on this particular crate right now, so I don't know when I'd get to it. I'll happily accept pull requests, though.

vorner avatar Oct 29 '18 08:10 vorner

Ok thanks for the information. For people having the same problem: I'm currently using hyper + jsonrpc_light, this way you can accept requests via hyper, deserialize them to jsonrpc_lite structs and also answer with those, giving a thin but already really helping layer between doing manual json and actually having magical glue from fn's to json. I don't know if it lacks anything specific but is working very good so far.

0xpr03 avatar Oct 29 '18 08:10 0xpr03