signal-hook icon indicating copy to clipboard operation
signal-hook copied to clipboard

Update LICENSE-MIT

Open maximevtush opened this issue 10 months ago • 5 comments

Updated the copyright year from 2017 to 2025 in the LICENSE file

maximevtush avatar Jan 29 '25 11:01 maximevtush

Hmm :thinking:

For one, I'm not sure it should be updated to 2025 if there was no change made in 2025.

But apparently, when looking at it, even the tokio-jsonrpc developers part is just a copy-paste from other project and obviously wrong.

I do wonder, how important is it to even have the file in the repository / or the first line? Isn't it enough that git preserves all the copyright info in the commits and that we say what the license is in the Cargo.toml?

vorner avatar Jan 29 '25 13:01 vorner

Hmm 🤔

For one, I'm not sure it should be updated to 2025 if there was no change made in 2025.

But apparently, when looking at it, even the tokio-jsonrpc developers part is just a copy-paste from other project and obviously wrong.

I do wonder, how important is it to even have the file in the repository / or the first line? Isn't it enough that git preserves all the copyright info in the commits and that we say what the license is in the Cargo.toml?

I can delete the year of copyright

maximevtush avatar Jan 29 '25 13:01 maximevtush

Deleting the year and fixing the owner might be the best :-)

vorner avatar Feb 08 '25 20:02 vorner

Deleting the year and fixing the owner might be the best :-)

what owner might be?

maximevtush avatar Feb 08 '25 20:02 maximevtush

I don't know if it's OK to just remove the owner. But if we need one, it would be signal-hook developers instead of tokio-jsonrpc developers

vorner avatar Feb 22 '25 09:02 vorner