Michael Vorburger comments

Results 604 comments of


                                            Michael Vorburger

Tests run: 66, Failures: 0, Errors: 5, Skipped: 10 with Kubo 0.33.2 (but 4 of the 5 work with old 0.18.1)

I'm curious if it works on CI. But https://github.com/ipfs-shipyard/java-ipfs-http-client/actions/workflows/ant.yml does not have any recent runs, only my (pending) #236. Maybe it would make sense to run it something like weekly?...

Tests run: 66, Failures: 0, Errors: 5, Skipped: 10 with Kubo 0.33.2 (but 4 of the 5 work with old 0.18.1)

At least 4 of the 5 are related to the ancient Kubo version v0.18.1 that the tests run against. If I [use docker-compose](https://github.com/ipfs-shipyard/java-ipfs-http-client?tab=readme-ov-file#docker-compose), then all except this work: ``` publish(io.ipfs.api.APITest)...

Tests run: 66, Failures: 0, Errors: 5, Skipped: 10 with Kubo 0.33.2 (but 4 of the 5 work with old 0.18.1)

FTR: Re. #236: Adding `--routing=dhtclient` (with Kubo 0.33.2), like `install-run-ipfs.sh`, does not "fix" (make any pass) these tests.

${group}/${artifact} variables not working in title: for kinds: maven

> Ah, and another obvious alternative is to use {dependencyId} everywhere, but you'd have ${group}:${artifact} equivalent (: instead of /) Thank You very much for posting this suggestion! I've (for...

Feature - Support Maven Central in the packaging check

> We test if mvn command is used in https://github.com/ossf/scorecard/blob/main/checks/fileparser/github_workflow.go#L462. E.g. for (my) https://github.com/MariaDB4j/MariaDB4j/ where I've added Scorecard in https://github.com/MariaDB4j/MariaDB4j/issues/661 on https://securityscorecards.dev/viewer/?uri=github.com/MariaDB4j/MariaDB4j it says `?` for Packaging and Signed-Releases. The...

Failed to create branch Untracked files: bazel-steward.jar

> I'll try to work around this by just adding bazel-steward.jar to .gitignore. https://github.com/enola-dev/enola/commit/4dc9fce19426de4b1eee6ab55af525083386b2ca helped (of course). Still seems weird though having to do this.

v0.11.2 has not been released to Bazel registry

@sgammon same for 0.12.0 as well... the `README` mentions it - but it's not on https://registry.bazel.build/modules/rules_graalvm. I guess that neccessarily means using `WORKSPACE.bazel` instead of `MODULE.bazel`, for now? Or is...

v0.11.2 has not been released to Bazel registry

``` bazelisk build //tools/hello:hello-native WARNING: Target pattern parsing failed. ERROR: Skipping '//tools/hello:hello-native': error loading package 'tools/hello': Unable to find package for @@[unknown repo 'rules_graalvm' requested from @@]//graalvm:defs.bzl: The repository '@@[unknown...

docs: Fix ancient leftover "test" comment for Meta

@danbri merge?

google-java-format Files list argument exceeds the OS limit

> [@macisamuele](https://github.com/macisamuele) IFF there was [google/google-java-format#1285](https://github.com/google/google-java-format/issues/1285), would you be open to a PR using that [here](https://github.com/macisamuele/language-formatters-pre-commit-hooks/blob/0ecd8f518d480ac640ddf6a426712510652c42b3/language_formatters_pre_commit_hooks/pretty_format_java.py#L188)? It turns out, see https://github.com/google/google-java-format/pull/1288, that `google-java-format` already (as-is) supports this: Using `@` reads...