ch.vorburger.exec icon indicating copy to clipboard operation
ch.vorburger.exec copied to clipboard
verified publisher icon vorburger

Performance issue

Open vorburger opened this issue 5 years ago • 2 comments

The wait(100) in ch.vorburger.exec.ManagedProcess.startExecute() isn't great.

Wouldn't some sort of yield() (:question:) suffice?

vorburger avatar Nov 15 '20 21:11 vorburger

@mosesn if you have any great idea how we could avoid this, go for (PR) it! I'm not entirely sure if #126 (alone) makes this unnecessary, now.

vorburger avatar Jun 16 '24 21:06 vorburger

Just to confirm, all we want to do is wait for asyncResult to complete for up to 100ms? Reading the logic I'm a bit confused–it seems like the logic is:

  1. wait for 100ms
  2. if the process threw an exception, bail out
  3. however, if the process started successfully OR if the process has not yet started, set the watchdog value

Do we want to preserve that behavior? or would we want to change it so that it bails out if it hasn't started within 100ms? Regardless, yes, this should be pretty easy to optimize.

mosesn avatar Jul 10 '24 12:07 mosesn