Ulysse
Ulysse
Are you sure your editor plugin uses the Merlin from this branch ? One way to do that is to use an opam pin: `opam pin merlin [email protected]:voodoos/merlin.git#fix-issue-1388`
Ok. Unfortunately I am not able to reproduce a similar issue on my test project any more. Could you provide a small project and a few reproduction steps ?
They have been multiple reports regarding weirdness happening when using ppxes. Merlin doesn't do a lot more than calling the ppx on the parse-tree before performing analysis over the result....
I would say something like `need-bench` ?
> Can I jump on the current reviews train? :D Sorry, it will have to be after the imminent release. I am curious: is that already in-use in OCaml-lsp ?
Our priority right now is the release but I can have a look shortly after if the goal is to have it upstreamed to not rely on another ocaml-lsp side's...
@ulugbekna could you move the clean-ups/refactoring parts of the PR to another one as you suggested ?
We also need to update the protocol documentation: https://github.com/ocaml/merlin/blob/master/doc/dev/PROTOCOL.md#type-enclosing--position-position---expression-string----cursor-int----index-int-
> but that document doesn't mention `-verbosity` at all? 🧐 looks like a great opportunity to do it 😅
Closing this issue since it is due to wrong locations in the PPX and not an ocaml-lsp/merlin issue.