Ulysse
Ulysse
For reference, here is the (quite large) diff in Merlin: https://github.com/ocaml/merlin/pull/1984
There are other indentation changes that are a bit surprising, like here: Or here:
> Looking at the surrounding code, this has the advantage that the sub-match has the same indentation as `Some (Sig_module (i, pr, m, Trec_not, Exported))`. Not sure that this is...
> Could you send text snippets by the way ? Its hard to investigate when there is nothing to copy paste For the begin match: ``` let () = match...
Yes, definitely an issue with the `end`.
Just tried it: the diff is still very large, but the `end` keywords are correctly indented now. We had a lot (I mean, a lot) of these in Merlin: https://github.com/ocaml/merlin/pull/1985/commits/7327450563114e06027d9203ed80dde5b35bec9e...
> I merged [#2742](https://github.com/ocaml-ppx/ocamlformat/pull/2742). Do you think we should do a release with some or all of these changes ? What are your plans for the next release @Julow ?...
No because we are have to build with OCaml 5.4. 25 nov. 2025 17:47:12 Jules Aguillon ***@***.***>: > > [Image]*Julow* left a comment (ocaml-ppx/ocamlformat#2741)[https://github.com/ocaml-ppx/ocamlformat/issues/2741#issuecomment-3576584581] > > > I usually prefer...