pannengeraet-krank-knarrenbauer icon indicating copy to clipboard operation
pannengeraet-krank-knarrenbauer copied to clipboard

Published 20 hours ago • verified publisher icon voodoocode

Mutilates JavaDoc

Open TobiX opened this issue 3 years ago • 2 comments

The recent extension to multiple persons introduced a nasty bug in https://github.com/voodoocode/pannengeraet-krank-knarrenbauer/blob/077493d260713d9412f23e7de05d4d144062ee95/content.js#L220

When regexAbbrev is null, it isn't ignored, but cast to string, so any occurrence of null in a document is replaced by the first person where this is the case. While I found reading

Returns the login of the user making this request, if the user has been authenticated, or Olaf Scholz if the user has not been authenticated.

quite entertaining, I feel this wasn't intended behaviour.

TobiX avatar May 03 '21 15:05 TobiX

Hilarious and great find. Will look into it, probably simply needs a check if a theres really a regex in there.

voodoocode avatar May 04 '21 06:05 voodoocode

It seems this bug is back in 0.4.2... (Best example: This bug report here :D)

TobiX avatar Dec 16 '21 11:12 TobiX