react-native-theme-control icon indicating copy to clipboard operation
react-native-theme-control copied to clipboard

Native controls don't seem to be themed properly

Open Nantris opened this issue 1 year ago • 3 comments

Native controls meaning: Alert, datetime picker, select, etc.


You can see the repro here:

Nantris/theme-control-demo

setThemePreference('dark') is called here: Nantris/theme-control-demo@master/App.js#L5


To build the project you can run:

eas build --profile=preview -p=android --local for the production-like APK or eas build --profile=devclient -p=android --local to build the dev-client for testing.

I installed the built app to my wireless-debugging connected device using adb install -r ./build-[datetime].apk


To demonstrate the issue:

Run the app (named theme-control-demo) and press the button to create an alert. The code dictates that the theme should be dark, but it's always light.

Nantris avatar Dec 04 '24 23:12 Nantris

@vonovak - Happy New Year! I wonder if you've had any new thoughts on what might cause this?

Thanks again for your great work!

Nantris avatar Jan 06 '25 22:01 Nantris

Friendly bump. If this worked it would be such a wonderful addition to the ecosystem.

Either way, thank you for all that you've already contributed!

Nantris avatar Feb 13 '25 03:02 Nantris

Hello, Apologies, I'll look into this, but might take a while, as I have other priorities,

If you contribute a PR with a fix, I'll be happy to merge it!

V.

vonovak avatar Feb 13 '25 07:02 vonovak

Hello, this was fixed in v7.0.1

Thank you!

vonovak avatar Jul 06 '25 16:07 vonovak