Matti Eiden

Results 66 comments of Matti Eiden

First) PEP 484 reads merely "As a shorthand for `Union[T1, None]` you can write `Optional[T1]`", so there's no official preference for either. SonarCloud does complain about `Union[T1, None]` though suggesting...

For priority, the to_gcode overhaul could be pretty high on the list. One large inconsistency that exists is the precision (gcode_precision). There are multiple places all over that require rounding...

Is this a reference to LinuxCNC docs? Well, maybe just go with 3 and 4 for now. Later this should be tied to post-processor as well. And also have separate...

setup.py also misses opencamlib/ocl - but that one doesn't have a PyPI package. Right now it's a hard requirement to import cq_cam but I'll make it optional by moving the...

Actually nope, too hasty on closing this one, sorry.

Definitely pretty tricky stuff, but voronoi can be used to find the largest circle that fits inside a polygon. That is definitely useful information for helical plunging. ![image](https://user-images.githubusercontent.com/437576/236678963-5ba8f1ae-f431-4afb-a895-9a545b23f669.png)

trimesh kinda works, but isn't very fast and uses evenly spaced approximation ![image](https://user-images.githubusercontent.com/437576/236679517-4b402476-1b61-4f52-9218-f9bc93a81ae7.png)

Clipper appears to be about 3x faster than using OCCT native implementation. The difference is fairly significant but comes with the cost of needing to interpolate arcs into line segments....

cadquery/cadquery#1130 is kind of a blocker for using wires/curves for calculating tabs. Or it requires a manual workaround of some kind.