Dale

Results 52 comments of Dale

So I took a stab at it (https://github.com/TwilightCoders/active_record-mti/commit/6edcb2bb00dd0f6aca533a95830106055d83fe4e). I changed the `User` model in the specs to use `ApplicationRecord`, but [specs did not fail](https://travis-ci.org/TwilightCoders/active_record-mti/builds/322962378). Maybe that's a starting point for...

@manuelmeurer Thanks for doing that! Hmm, PostgreSQL `v10.x` sounded like a good theory; it looks like the specs passed though. 🤔 Have you got other `ActiveRecord::Base` extensions (gems) in your...

Oh wow. Great find! That was an attempt to make sure setting a table_name explicitly still worked (that I didn't botch that functionality). Looks like I need do have another...

Alright @manuelmeurer @yuki24, I've [refactored](https://github.com/TwilightCoders/active_record-mti/commit/836aad6d405a62628e8e811f38833c991f019bc9#diff-450039e1f6b834bb35ca4b9f56671a6f) how `MTI` handles `table_name` inference. I also took some time to [clean up the specs](https://github.com/TwilightCoders/active_record-mti/commit/de4beea37bde2e7d616ae413f9864aebb1c910a9) around a lot of this. [Builds are passing (naturally)](https://travis-ci.org/TwilightCoders/active_record-mti/builds/323281893). Additionally,...

@yuki24 Happy (belated) Holidays to you too! Thanks for that overhaul. It's definitely intriguing. I see a lot of cool solutions in there. I'm still picking through the changeset, I'll...

Hey all, I got around to merging in a bunch of the work @yuki24 did. It's much less polluty (it's a word now :P). It's not quite ready for primetime,...

Hey @manuelmeurer, here are my thoughts on @yuki24's concerns! - **ActiveRecord::Base Pollution** _(concern no. 1)_ - I'd argue that this isn't a very good argument. This is pretty much table-stakes...

Hey @yuki24, >If you think so, please do continue to maintain the project! It's just my concern and that shouldn't stop you from what you are doing. And I'm always...

Hi @sjaveed, thanks for reaching out. The project is semi-maintained. I'm sitting on a huge refactor that is about 98% complete, with one edge case that I'm still trying to...

Ah shoot. Sorry you spent time on this, the work I have in flight is not up on GitHub. I'll try to wrap it up and push it up soon,...