ts-ocpp icon indicating copy to clipboard operation
ts-ocpp copied to clipboard

Auto-generated SOAP typings do not respect optional properties

Open eduhenke opened this issue 4 years ago • 0 comments

For example the StartTransaction response, contains an idTagInfo field of IdTagInfo type. As per the OCPP v1.5 SOAP specification, the fields parentIdTag and expiryDate of the IdTagInfo type are optional. However they currently are mandatory via the types, but they should be optional. This occurs in various types that were generated per the WSDL files.

It would provide a more correct typing system, if either:

  • The SOAP generation instructions(https://github.com/voltbras/ts-ocpp/tree/main/packages/messages/soap/wsdl) are adjusted to fix this problem
  • Or we completely disassociate from the original WSDL files and manually fine-tune all the SOAP generated typings.

eduhenke avatar Mar 26 '21 03:03 eduhenke