volta icon indicating copy to clipboard operation
volta copied to clipboard

No more symlinks on Windows

Open rcsilva83 opened this issue 2 years ago • 4 comments

Replace file symlink by shims and dir symlinks on Windows by junctions

closes #1397

rcsilva83 avatar Sep 19 '23 21:09 rcsilva83

Hi,

I'm trying to fix the tests but I couldn't make them load on VS Code's Testing panel. I'm not a Rust developer but I'm searching on the Internet and installed all VS Code's extensions for Rust testing and I couldn't make it work. Can someone help me?

rcsilva83 avatar Sep 27 '23 13:09 rcsilva83

@charlespierce is there anything else I need to do?

rcsilva83 avatar Nov 08 '23 19:11 rcsilva83

Any update? Could be awesome to merge it is ready to allow company-constrained environment to run Volta.

Xstoudi avatar Mar 14 '24 09:03 Xstoudi

Running hyperfine, this is the result on the current Volta official release on my Windows 10 virtual machine:

Benchmark 1: node -v
  Time (mean ± σ):      47.7 ms ±  10.7 ms    [User: 13.1 ms, System: 25.8 ms]
  Range (min … max):    40.0 ms …  93.9 ms    57 runs

And this is the result on the release exec compiled from this pull request, again on my Windows 10 virtual machine:

Benchmark 1: node -v
  Time (mean ± σ):      46.7 ms ±   3.6 ms    [User: 12.8 ms, System: 29.7 ms]
  Range (min … max):    42.8 ms …  65.0 ms    55 runs

I'm not really sure how to interpret this and it's the first time I ever use hyperfine.

Xstoudi avatar Mar 22 '24 21:03 Xstoudi

Closing now, as we landed #1755. Thank you again for getting the ball rolling and doing a ton of research and implementation work, @rcsilva83! This will be a big win for our upcoming 2.0 release!

chriskrycho avatar Jul 09 '24 22:07 chriskrycho