vzlogger icon indicating copy to clipboard operation
vzlogger copied to clipboard

Implement scaler for all sources

Open RalfGebhard opened this issue 4 years ago • 2 comments

Scaler currently doesn’t work for sml meters, But for scaling meters “Messwandelzähler”, their output is a fragment of the real output.

Ralf

RalfGebhard avatar Feb 02 '21 21:02 RalfGebhard

so you are refering to the scaler channel property,

which is only implemented for MeterOCR: https://github.com/volkszaehler/vzlogger/blob/1a6e10b6d8d69282f3df8152c35ce1b1f19baad7/etc/vzlogger_generic.schema.json#L743 https://github.com/volkszaehler/vzlogger/blob/1a6e10b6d8d69282f3df8152c35ce1b1f19baad7/src/protocols/MeterOCR.cpp#L132 and the mysmartgrid API: https://github.com/volkszaehler/vzlogger/blob/1a6e10b6d8d69282f3df8152c35ce1b1f19baad7/etc/vzlogger_generic.schema.json#L151 https://github.com/volkszaehler/vzlogger/blob/1a6e10b6d8d69282f3df8152c35ce1b1f19baad7/src/api/MySmartGrid.cpp#L84

actually this looks like a BUG to me: if one was logging an OCR-meter to a mysmartgrid server, the scaler would be applied twice?!

the implementation should probably be moved to a central place (the Reading{} class?), where it would apply to all meters, instead of only specific meters or apis.

r00t- avatar Mar 09 '21 23:03 r00t-

there seems to be a partial fix in https://github.com/volkszaehler/vzlogger/issues/245

r00t- avatar Mar 11 '21 05:03 r00t-