vzlogger icon indicating copy to clipboard operation
vzlogger copied to clipboard

Published 20 hours ago • verified publisher icon volkszaehler

should log its PID on startup

Open Zugschlus opened this issue 5 years ago • 3 comments

Hi,

vzlogger should, at least in the more verbose log levels, write its pid to the log. That would make debugging way easier.

Greetings Marc

Zugschlus avatar May 29 '19 10:05 Zugschlus

do we also want a pidfile, or is logging sufficient?

r00t- avatar Mar 12 '21 01:03 r00t-

also, now that we have --foreground, this is much less critical.

r00t- avatar Mar 12 '21 01:03 r00t-

A pidfile would allow to write a way more robust sysv init script. In the systemd world, that is not really necessary since systemd puts each service in its own process group and simply kills off everything that is in the process group. Since I am using systemd, I don't have a strong opinion about that.

Logging the pid is most probably a trivial one-line change, that is really worth doing.

Zugschlus avatar Mar 14 '21 13:03 Zugschlus