Vikram Voleti
Vikram Voleti
@claforte Redone, also merged latest changes to main
Looks good to me!
I've folded guidance_eval_save into base.py, and address the comments. Please check!
Tested! Merging with main
1. The problem indeed was not being able to access global_step in the data, I "fixed" that by making data.collate fn record its own step. 2. radius/fovy start from the...
True, I wanted to implement progressive_view within update_step initially (check https://github.com/threestudio-project/threestudio/pull/165/commits/4cf6f1b84d7ad0bb74b76cc634b0ce02a324ef51), but I noticed that update_step is never called anywhere. Can you point to how it could be used?
My typical command for it is: `python launch.py --config configs/experimental/imagecondition_zero123nerf.yaml --train --gpu 0 system.prompt_processor.prompt="A DSLR 3D photo of a cute anime schoolgirl stands proudly with her arms in the air,...
@bennyguo I've added Updateable at the right place, please check! I've also added changing of batch_size with resolution_milestone, please check!
Agreed! I didn't want to introduce 4 more parameters (elevation_range_min, elevation_range_max, azimuth_range_min, azimuth_range_max) that could be specified with [start_iter, start_val, end_val, end_iter]. I opted to introduce only one more `progressive_until`....
LGTM! Minor comments only