verl icon indicating copy to clipboard operation
verl copied to clipboard

fix(vllm): fix typo in async server initialization

Open omkarrr2533 opened this issue 3 weeks ago • 1 comments

What does this PR do?

Fixes typos in async server initialization code.

Changes Made

  1. Fixed typo in vllm_async_server.py initialization
  2. Fixed run_unvicornrun_uvicorn typo in all files:
    • verl/workers/rollout/vllm_rollout/vllm_async_server.py
    • verl/workers/rollout/utils.py
    • verl/workers/rollout/sglang_rollout/async_sglang_server.py
  3. Code formatted with ruff (auto)

Testing

  • [x] Code compiles without errors
  • [x] No syntax issues detected
  • [x] Ruff formatting passes
  • [x] Mypy type checking passes
  • [x] License headers verified

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective (N/A for typo fixes)

Notes

  • Development on Windows; some pre-commit hooks were skipped due to platform differences
  • Addressed review feedback from @gemini-code-assist

omkarrr2533 avatar Dec 02 '25 15:12 omkarrr2533

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 02 '25 15:12 CLAassistant