verl icon indicating copy to clipboard operation
verl copied to clipboard

[rollout] feat: add support for discriminative reward model in reward loop

Open yyDing1 opened this issue 1 month ago • 1 comments

What does this PR do?

Reward computation in reward loop will follow the design below:

Reward Computation Logic:
- if user-customized reward function is provided:
    -> directly use user-customized reward function
- if user-customized reward function is not provided:
    -> rm is not enabled: use default rule-based reward function
    -> rm is disrm: compute reward score using disrm
    -> rm is genrm: raise error (user-costomized reward func must be provided)

This PR adds support for DisRM and polishes some code for GenRM and Rule-Based reward, with corresponding ci tests.

The legacy FSDP/Megatron reward models can soon be deprecated, as all scenarios are supported (i.e., rule, disrm, genrm).

Checklist Before Starting

  • [ ] Search for similar PRs. Paste at least one query link here: ...
  • [ ] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

yyDing1 avatar Nov 29 '25 17:11 yyDing1

we should also update document.

wuxibin89 avatar Dec 02 '25 03:12 wuxibin89