verl icon indicating copy to clipboard operation
verl copied to clipboard

[perf] fix: profiler bug fix for agent loop

Open mengchengTang opened this issue 1 month ago • 3 comments

What does this PR do?

Updated Description: This PR fixes the missing rollout profiling data issue caused by the Agent Loop architecture shift.

Root Cause: Inference requests now bypass the generate_sequences method of the worker, causing missing performance data during the rollout phase in Discrete Mode.

Solution: We add explicit profiling control to support the current rollout workers. This is a backward-compatible fix. New methods start_capture_profile and stop_capture_profile in DistProfiler and Workers. AgentLoopManager now manually starts and stops profiling via vLLMReplica around inference requests.

This ensures existing rollout workers can collect performance data correctly.

Checklist Before Starting

  • [x] Search for similar PRs. Paste at least one query link here: ...
  • [x] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

mengchengTang avatar Nov 27 '25 06:11 mengchengTang

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 27 '25 06:11 CLAassistant

It can be seen that the overall process control and the actual profiling startup are far apart, and the original solution requires passing the calling function many times, which is not elegant enough.

tardis-key avatar Nov 28 '25 07:11 tardis-key

@FightingZhen @wuxibin89 ready for review. This pr is bugfix for legacy_workers.

tardis-key avatar Dec 04 '25 11:12 tardis-key

Is there any way to unify start_e2e_profiler and start_capture_profiler?

tardis-key avatar Dec 17 '25 01:12 tardis-key