verl icon indicating copy to clipboard operation
verl copied to clipboard

[megatron] fix: Use tokenizer path or model path in config

Open ashvinnihalani opened this issue 1 month ago • 2 comments

When initializing the hf config first try to use the tokenizer config if avaiable then try to do the model path. Useful if you are trying to introduce a new tokenizer

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • [X ] Search for similar PRs. Paste at least one query link here: https://github.com/volcengine/verl/pulls?q=is%3Apr+Use+tokenizer+path+is%3Aopen
  • [X ] Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

[!IMPORTANT] Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

ashvinnihalani avatar Nov 11 '25 21:11 ashvinnihalani

please fix the CI

ISEEKYAN avatar Nov 12 '25 11:11 ISEEKYAN

Resolved @ISEEKYAN

ashvinnihalani avatar Nov 17 '25 06:11 ashvinnihalani