volcano
volcano copied to clipboard
Only refresh podgroup to running when pods are scheduled
What type of PR is this?
/kind bug
What this PR does / why we need it:
When pod bind/preBind fails, the pod has been resynced, but the pg remains in running state, which may confuse users.Now only the number of scheduled pods( Bound/Running) exceed the minAvailable will refresh the podgroup to Running, allocated/binding in session currently will not be counted
Which issue(s) this PR fixes:
Fixes # https://github.com/volcano-sh/volcano/issues/4383
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Now only the number of scheduled pods(Bound/Running) exceed the minAvailable will refresh the podgroup to Running, allocated/binding pods recorded in session currently will not be counted
After modification, if prebind fails, then podgroup will keep in Inqueue state and will not be refreshed to Running state:
/cc @lowang-bh @hwdef @Monokaix
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Monokaix
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [Monokaix]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm