volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Only refresh podgroup to running when pods are scheduled

Open JesseStutler opened this issue 5 months ago • 2 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

When pod bind/preBind fails, the pod has been resynced, but the pg remains in running state, which may confuse users.Now only the number of scheduled pods( Bound/Running) exceed the minAvailable will refresh the podgroup to Running, allocated/binding in session currently will not be counted

Which issue(s) this PR fixes:

Fixes # https://github.com/volcano-sh/volcano/issues/4383

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Now only the number of scheduled pods(Bound/Running) exceed the minAvailable will refresh the podgroup to Running, allocated/binding pods recorded in session currently will not be counted

JesseStutler avatar Jun 19 '25 07:06 JesseStutler

After modification, if prebind fails, then podgroup will keep in Inqueue state and will not be refreshed to Running state: image

JesseStutler avatar Jun 19 '25 08:06 JesseStutler

/cc @lowang-bh @hwdef @Monokaix

JesseStutler avatar Jun 23 '25 06:06 JesseStutler

/approve

Monokaix avatar Jul 07 '25 07:07 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jul 07 '25 07:07 volcano-sh-bot

/lgtm

hwdef avatar Jul 07 '25 09:07 hwdef