volcano icon indicating copy to clipboard operation
volcano copied to clipboard

feat: add queue-level scheduling policy

Open ElectricFish7 opened this issue 5 months ago • 4 comments

What type of PR is this?

Add queue-level scheduling policies

What this PR does / why we need it:

This PR introduces queue-level scheduling policy. As outlined in the implementation section of the design document(https://github.com/volcano-sh/volcano/pull/4163), it enables configuring different Actions and Plugins per queue using the SchedulingPolicy. This design also allows for straightforward extension to job-level policies in the future.

Note:

  • Before merging this branch, it’s recommended to first merge https://github.com/volcano-sh/apis/pull/176.
  • Related test cases will be demonstrated in this document: Test Plan

Which issue(s) this PR fixes:

Fixes #https://github.com/volcano-sh/volcano/issues/3992

Special notes for your reviewer:

@Monokaix @JesseStutler

Does this PR introduce a user-facing change?


ElectricFish7 avatar Jun 17 '25 12:06 ElectricFish7

/cc

JesseStutler avatar Jun 17 '25 12:06 JesseStutler

/cc will review this week 😄

googs1025 avatar Jun 18 '25 07:06 googs1025

Made the following changes based on the weekly meeting discussion:

  • Moved the assignment of jobinfo.schedulingPolicy, taskinfo.schedulingPolicy, queueinfo.schedulingPolicy to the openSession phase.
  • Updated the logging related to reading the SchedulingPolicy.

Additionally, it was found that using DefaultSchedulingPolicy conflicts with the extension points in ssn, therefore, the global configuration is still kept in ssn.

ElectricFish7 avatar Jun 21 '25 01:06 ElectricFish7

Great work!

kingeasternsun avatar Jun 25 '25 01:06 kingeasternsun

/assign @JesseStutler /assign @Monokaix

ElectricFish7 avatar Sep 18 '25 02:09 ElectricFish7

Please rebase master and solve code conflict.

Monokaix avatar Sep 30 '25 07:09 Monokaix

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign monokaix You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Sep 30 '25 07:09 volcano-sh-bot

@ElectricFish7: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Nov 02 '25 01:11 volcano-sh-bot