volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Support the allocation callback function provided by the extender.

Open zhifei92 opened this issue 5 months ago • 9 comments

What type of PR is this?

What this PR does / why we need it:

Similar to plugins such as Predicate and Prioritize, AllocateFunc and DeallocateFunc should also be configurable.

Which issue(s) this PR fixes:

Fixes #4376

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support for registering `AllocateFunc` and `DeallocateFunc` in the extender by calling `ssn.AddEventHandler`.

zhifei92 avatar Jun 16 '25 09:06 zhifei92

Welcome @zhifei92!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Jun 16 '25 09:06 volcano-sh-bot

@zhifei92 Please sign your commit using git commit -s

JesseStutler avatar Jun 17 '25 11:06 JesseStutler

Please sign your commit using git commit -s

done

zhifei92 avatar Jun 17 '25 12:06 zhifei92

/ok-to-test

JesseStutler avatar Jun 17 '25 12:06 JesseStutler

/ok-to-test @zhifei92 Also please squash your commits into one, thanks :)

JesseStutler avatar Jun 18 '25 01:06 JesseStutler

/copilot request review

zhifei92 avatar Jun 18 '25 13:06 zhifei92

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@JesseStutler @Monokaix I noticed that the Copilot review failed with an error. Should we try re-requesting the Copilot review? Thanks for your time and support!

zhifei92 avatar Jun 18 '25 13:06 zhifei92

I think it's fine

/lgtm

JesseStutler avatar Jun 20 '25 02:06 JesseStutler

/cc @Monokaix

JesseStutler avatar Jun 20 '25 02:06 JesseStutler

/approve

Monokaix avatar Jun 20 '25 06:06 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jun 20 '25 06:06 volcano-sh-bot