volcano
volcano copied to clipboard
Support the allocation callback function provided by the extender.
What type of PR is this?
What this PR does / why we need it:
Similar to plugins such as Predicate and Prioritize, AllocateFunc and DeallocateFunc should also be configurable.
Which issue(s) this PR fixes:
Fixes #4376
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Added support for registering `AllocateFunc` and `DeallocateFunc` in the extender by calling `ssn.AddEventHandler`.
Welcome @zhifei92!
It looks like this is your first PR to volcano-sh/volcano.
Thank you, and welcome to Volcano. :smiley:
@zhifei92 Please sign your commit using git commit -s
Please sign your commit using
git commit -s
done
/ok-to-test
/ok-to-test @zhifei92 Also please squash your commits into one, thanks :)
/copilot request review
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
@JesseStutler @Monokaix I noticed that the Copilot review failed with an error. Should we try re-requesting the Copilot review? Thanks for your time and support!
I think it's fine
/lgtm
/cc @Monokaix
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Monokaix
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/plugins/OWNERS~~ [Monokaix]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment