volcano-sh
Set root capability only when user not set it
Fixes #4350
Result:
UT- when I use old code, I got:
UT- when I use new code, I got:
/lgtm Please also take a look @hwdef @lowang-bh @Monokaix I think it's reasonable when users want to pre-set the capability for the root queue
That's a good catch, and @Xu-Wentao also has the same requirement, and I think that we can add root queue at helm chart, then user can set the spec of root queue when install volcano, and we can remove root queue creation operation in volcano scheduler.
@Monokaix Good idea and we can open another feature issue and track it. If you have time，please give me approve, thanks.
@Monokaix Good idea and we can open another feature issue and track it. If you have time，please give me approve, thanks.
OK @houyuting Would you like to raise this issue? Otherwise we may miss it :)
The root queue will also be updated when close session, so it's not enough to just modify plugin.
The root queue will also be updated when close session, so it's not enough to just modify plugin.
got it
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Monokaix
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [Monokaix]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
