volcano icon indicating copy to clipboard operation
volcano copied to clipboard

network topology aware hard mode support hypernode binpack

Open kingeasternsun opened this issue 6 months ago • 1 comments

What type of PR is this?

hard mode support hypernode binpack.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes https://github.com/volcano-sh/volcano/issues/4331

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Hard mode support hypernode binpack.

kingeasternsun avatar Jun 05 '25 01:06 kingeasternsun

Please fix the CI, thanks :)

JesseStutler avatar Jul 03 '25 02:07 JesseStutler

Please fix the CI, thanks :)

Fixed.

kingeasternsun avatar Jul 04 '25 06:07 kingeasternsun

Should squash your commits into one, thanks Also /cc @Monokaix

Done. @Monokaix

kingeasternsun avatar Jul 16 '25 03:07 kingeasternsun

Is HyperNode level score strategy introduced? Seems only HyperNode level score can handle this.

Monokaix avatar Jul 17 '25 07:07 Monokaix

Is HyperNode level score strategy introduced? Seems only HyperNode level score can handle this.

The nodeFn incorporates hyperNode awareness but lacks hyperNode-level scoring strategies. As demonstrated by the new test cases, this approach effectively resolves the reported issue.

kingeasternsun avatar Jul 24 '25 06:07 kingeasternsun

Please squash your commits into one, thanks. Should not show up commit like merge master into

JesseStutler avatar Aug 11 '25 01:08 JesseStutler

/gemini review

JesseStutler avatar Aug 11 '25 01:08 JesseStutler

/approve

Monokaix avatar Sep 15 '25 07:09 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Sep 15 '25 07:09 volcano-sh-bot

/lgtm

JesseStutler avatar Sep 17 '25 01:09 JesseStutler