volcano icon indicating copy to clipboard operation
volcano copied to clipboard

refactor: refactor resource reclamation

Open elysium-w opened this issue 7 months ago • 8 comments

…rove readability and maintainability.

What type of PR is this?

What this PR does / why we need it:

refactor resource reclamation into modular functions to improve readability and maintainability.

Which issue(s) this PR fixes:

Fixes #3738

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

elysium-w avatar Apr 28 '25 08:04 elysium-w

@elysium-w: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Apr 28 '25 08:04 volcano-sh-bot

@hwdef @Monokaix @JesseStutler PTAL

elysium-w avatar Apr 28 '25 08:04 elysium-w

a little big. I'll check this later.

hwdef avatar Apr 28 '25 13:04 hwdef

@hwdef @Monokaix @JesseStutler If you have time, please take a look. Thank you very much.

elysium-w avatar May 05 '25 15:05 elysium-w

/cc

JesseStutler avatar May 06 '25 03:05 JesseStutler

/ok-to-test

lowang-bh avatar May 10 '25 13:05 lowang-bh

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jul 28 '25 13:07 volcano-sh-bot