volcano icon indicating copy to clipboard operation
volcano copied to clipboard

[Refactor] Extraction of common code modules(job_controller_handler)

Open feyounger opened this issue 7 months ago • 5 comments

What type of PR is this?

Add req to the queue in multiple places in job_controller_handler.go

What this PR does / why we need it:

The code is clearer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

none

Does this PR introduce a user-facing change?

none

feyounger avatar Apr 22 '25 06:04 feyounger

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign hwdef You can assign the PR to them by writing /assign @hwdef in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Apr 22 '25 06:04 volcano-sh-bot

/lgtm not refactor, just clean up

hwdef avatar Apr 22 '25 11:04 hwdef

/lgtm not refactor, just clean up

ok,I agree with your statement

feyounger avatar Apr 23 '25 06:04 feyounger

rename to addJobInQueue is more proper

others lgtm

year

feyounger avatar May 11 '25 10:05 feyounger

New changes are detected. LGTM label has been removed.

volcano-sh-bot avatar May 11 '25 10:05 volcano-sh-bot