volcano icon indicating copy to clipboard operation
volcano copied to clipboard

test: add e2e test cases for hypernode

Open Xu-Wentao opened this issue 1 year ago • 4 comments

What type of PR is this?

/area test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Support https://github.com/volcano-sh/volcano/issues/3928

Special notes for your reviewer:

Use kwok to create multi worker nodes.

Does this PR introduce a user-facing change?


Xu-Wentao avatar Jan 23 '25 10:01 Xu-Wentao

You also need to add a workflow action yaml in .github/workflows dir

JesseStutler avatar Feb 10 '25 12:02 JesseStutler

/assign Will take a look in recent days

JesseStutler avatar May 15 '25 03:05 JesseStutler

Can you also open the plugin network-topology-aware in https://github.com/volcano-sh/volcano/blob/network-topology/installer/helm/chart/volcano/config/volcano-scheduler-ci.conf?

We can add more case such as:

  1. Under hard mode, some pods in vcjob have already been scheduled to the same hypernode (highestAllowedTier). Then, when scheduling the remaining pods in vcjob for the second time (you can schedule all pods in vcjob first, and then delete one or two pods to trigger the second scheduling of these pods), these pods still need to be scheduled to the same hypernode, and the lower the tier of this hypernode, the better.

JesseStutler avatar May 20 '25 03:05 JesseStutler

/remove-area cli /remove-area scheduling /remove-area controllers /remove-area dependency /remove-area webhooks /remove-area deploy /remove-area documentation /remove-area performance /area test /remove-kind documentation /remove-kind feature /remove-kind failing-test /remove-kind cleanup /remove-kind flake /remove-kind bug

JesseStutler avatar Jun 23 '25 13:06 JesseStutler

Please also clean your commits into one thanks, one more step we can merge it :)

JesseStutler avatar Jun 23 '25 13:06 JesseStutler

Please also clean your commits into one thanks, one more step we can merge it :)

done.

Xu-Wentao avatar Jun 23 '25 23:06 Xu-Wentao

@JesseStutler: Those labels are not set on the issue: area/cli, area/scheduling, area/controllers, area/dependency, area/webhooks, area/deploy, area/documentation, area/performance, kind/documentation, kind/feature, kind/failing-test, kind/cleanup, kind/flake

In response to this:

/remove-area cli /remove-area scheduling /remove-area controllers /remove-area dependency /remove-area webhooks /remove-area deploy /remove-area documentation /remove-area performance /area test /remove-kind documentation /remove-kind feature /remove-kind failing-test /remove-kind cleanup /remove-kind flake /remove-kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Jun 24 '25 01:06 volcano-sh-bot

/cc @Monokaix @hwdef @lowang-bh

JesseStutler avatar Jun 28 '25 03:06 JesseStutler

/approve

Monokaix avatar Aug 04 '25 03:08 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Aug 04 '25 03:08 volcano-sh-bot