volcano icon indicating copy to clipboard operation
volcano copied to clipboard

fix: vgpu metrics repeated accumulation error

Open yaoyinnan opened this issue 11 months ago • 9 comments

The vgpu metrics vgpu_device_allocated_memory and vgpu_device_allocated_cores have cumulative errors due to repeated calculations. AddResource()/SubResource() calculates them once before calling AddPodMetrics()/SubPodMetrics() and should not be calculated again.

Signed-off-by: yaoyinnan [email protected]

yaoyinnan avatar Dec 15 '24 15:12 yaoyinnan

Welcome @yaoyinnan!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Dec 15 '24 15:12 volcano-sh-bot

@archlitchi Please help me review. thanks.

yaoyinnan avatar Dec 15 '24 16:12 yaoyinnan

/lgtm

by the way, do you have a related issue submitted?

archlitchi avatar Dec 18 '24 02:12 archlitchi

/ok-to-test

Monokaix avatar Jan 06 '25 02:01 Monokaix

/approve

Monokaix avatar Jan 06 '25 02:01 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Jan 06 '25 02:01 volcano-sh-bot

please make CI happy

hwdef avatar Jan 06 '25 03:01 hwdef

New changes are detected. LGTM label has been removed.

volcano-sh-bot avatar Mar 29 '25 01:03 volcano-sh-bot

@yaoyinnan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

volcano-sh-bot avatar Jun 01 '25 01:06 volcano-sh-bot