volcano
volcano copied to clipboard
fix: vgpu metrics repeated accumulation error
The vgpu metrics vgpu_device_allocated_memory and vgpu_device_allocated_cores have cumulative errors due to repeated calculations. AddResource()/SubResource() calculates them once before calling AddPodMetrics()/SubPodMetrics() and should not be calculated again.
Signed-off-by: yaoyinnan [email protected]
Welcome @yaoyinnan!
It looks like this is your first PR to volcano-sh/volcano.
Thank you, and welcome to Volcano. :smiley:
@archlitchi Please help me review. thanks.
/lgtm
by the way, do you have a related issue submitted?
/ok-to-test
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Monokaix
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [Monokaix]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
please make CI happy
New changes are detected. LGTM label has been removed.
@yaoyinnan: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.