volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Every pg will record a Unschedulable type event fisrt no matter whether resources are enough and then schedule successfully.

Open liuyuanchun11 opened this issue 1 year ago • 4 comments

Description

  1. duplicated condition update with Unschedulable and Scheduled, just retain one Scheduled is enough.
  2. and add an extended condition to express the Unenqueueable event.
  3. every pg will record a Unschedulable type event fisrt no matter whether resources are enough and then schedule successfully.

Steps to reproduce the issue

  1. Create a vcjob in a cluster with sufficient resources. The vcjob is scheduled normally and is in the running state.
  2. Execute "kubectl describe pg xxx", will see podgroup contains conditions that unschedulable and scheduled. 3.Execute “kubectl get events --sort-by='.metadata.creationTimestamp'”, will see warning event "job xxx unscheduler, reasion:...."

Describe the results you received and expected

expected:

  1. Only one condition is used to describe podgroup scheduling.
  2. No unscheduable warning event occurs in the pod group that is normally scheduled.

What version of Volcano are you using?

v1.9.0

Any other relevant information

No response

liuyuanchun11 avatar Sep 26 '24 06:09 liuyuanchun11

I think it's a good issue. /cc @Monokaix

JesseStutler avatar Sep 26 '24 06:09 JesseStutler

/assign

JesseStutler avatar Sep 26 '24 06:09 JesseStutler

as for point 2, there is already an PR #3045.

lowang-bh avatar Oct 08 '24 03:10 lowang-bh

as for point 2, there is already an PR #3045.

Maybe we can add a new condition type named Unenqueueable instead of a reason attached to Unschedulable.

Monokaix avatar Oct 08 '24 09:10 Monokaix

Hello 👋 Looks like there was no activity on this issue for last 90 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

stale[bot] avatar Feb 01 '25 01:02 stale[bot]

Any progress?

hwdef avatar Feb 06 '25 07:02 hwdef

Not yet, I will record temporaily until I have time to fix it

JesseStutler avatar Feb 10 '25 11:02 JesseStutler