volcano icon indicating copy to clipboard operation
volcano copied to clipboard

Add queue priority

Open TaiPark opened this issue 1 year ago • 1 comments

Add queue priority. Related issue: https://github.com/volcano-sh/volcano/issues/3542 Design doc for queue priority: https://github.com/volcano-sh/volcano/pull/3602. https://github.com/volcano-sh/apis/pull/132 in Volcano-apis should be merged before this PR.

TaiPark avatar Aug 29 '24 07:08 TaiPark

please add unit case to cover your code. thanks

lowang-bh avatar Aug 30 '24 04:08 lowang-bh

please add unit case to cover your code. thanks

UT in capacity_test and proportion_test already added

TaiPark avatar Sep 02 '24 10:09 TaiPark

Please rebase master and squash to one commit.

Monokaix avatar Sep 02 '24 11:09 Monokaix

Missing https://github.com/volcano-sh/apis/pull/128 in Volcano-Apis release v1.10, should I also cherry pick it?

TaiPark avatar Sep 04 '24 03:09 TaiPark

Missing volcano-sh/apis#128 in Volcano-Apis release v1.10, should I also cherry pick it?

pr: https://github.com/volcano-sh/apis/pull/136

TaiPark avatar Sep 04 '24 04:09 TaiPark

/lgtm

Monokaix avatar Sep 04 '24 08:09 Monokaix

overall, it is ok for me.

william-wang avatar Sep 05 '24 03:09 william-wang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Sep 05 '24 03:09 volcano-sh-bot