volcano icon indicating copy to clipboard operation
volcano copied to clipboard

add webhook for jobflow and jobtemplate

Open hwdef opened this issue 1 year ago • 4 comments

What is the problem you're trying to solve

Currently there is no check when creating jobflow and jobtemplate, this may cause the controller or scheduler to panic.

Describe the solution you'd like

add some check in admission for jobflow and jobtemplate.

Additional context

No response

hwdef avatar Aug 07 '24 08:08 hwdef

/assign

hwdef avatar Aug 07 '24 08:08 hwdef

Hi, please descriebe what checks are missing and why volcano will panic.

Monokaix avatar Aug 08 '24 02:08 Monokaix

For jobflow:

  • The jobtemplate in jobflow cannot be repeated
  • The jobtemplate in the job cannot form a ring, which means that the jobtemplate needs to be a DAG.

For jobtemplate:

  • It should be the same as vcjob's vaildate

hwdef avatar Aug 29 '24 10:08 hwdef

Jobtemlpate should reuse job's validate. Do you have any good suggestions?

hwdef avatar Aug 29 '24 10:08 hwdef

Hello 👋 Looks like there was no activity on this issue for last 180 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for 90 days, this issue will be closed (we can always reopen an issue if we need!).

stale[bot] avatar Apr 25 '25 23:04 stale[bot]

can this https://github.com/volcano-sh/volcano/pull/4122 help?

Monokaix avatar Jun 03 '25 07:06 Monokaix