volcano
volcano copied to clipboard
feature: use multi factor for overcommit plugin
What type of PR is this?
/kind feature
What this PR does / why we need it:
- different resources should have different factors, so using the same overcommit-factor is not appropriate.
Which issue(s) this PR fixes:
https://github.com/volcano-sh/volcano/issues/3635
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
User could give different overcommit factors (cpu-overcommit-factor, mem-overcommit-factor, other-overcommit-factor, overcommit-factor) through overcommit plugin arguments
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Please refer to predicate.Proportional function in predicate plugin.
/hold
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
/reopen
@googs1025: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.