volcano icon indicating copy to clipboard operation
volcano copied to clipboard

fix(controller): add statefulset gc for podgroup.

Open HalfBuddhist opened this issue 1 year ago • 6 comments

what to fix?

While scheduling a k8s statefulset using volcano, the generated podgroup of the related pods will be in Inqueue state even when setting the replica of the statefulset to zero. And the Inqueued podgroup would still occupy resources, which is not reasonable.

how to reproduce it?

scheduling a statefulset using volcano and scale it to zero.

how to fix in ths pr?

put a informer in controller, delete the pgs for the zero-replica statefulset in the add and the update event.

HalfBuddhist avatar Jul 17 '24 03:07 HalfBuddhist

Welcome @HalfBuddhist!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar Jul 17 '24 03:07 volcano-sh-bot

Hi, please sign off your commit with git commit -s. And please note that https://github.com/volcano-sh/volcano/pull/3561 has fixed some problems about pg, you can refer it.

Monokaix avatar Jul 18 '24 09:07 Monokaix

  1. add sign-off to commit message.
  2. do the same fix in #3561 when rolling upgrade statefulset.

HalfBuddhist avatar Jul 23 '24 11:07 HalfBuddhist

Thanks for your contribution ,this case should also be considered: )

Monokaix avatar Sep 29 '24 02:09 Monokaix

Thanks for your contribution ,this case should also be considered: )

Please also consider this: https://github.com/volcano-sh/volcano/pull/3672

Monokaix avatar Oct 11 '24 02:10 Monokaix

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Feb 01 '25 01:02 stale[bot]

still need

hwdef avatar Feb 06 '25 02:02 hwdef

Thanks for your contribution ,this case should also be considered: )

Please also consider this: #3672

Done in commit e1c17e9bf7bdeed8491867f9324dcb06ac93eceb @Monokaix

HalfBuddhist avatar Feb 07 '25 10:02 HalfBuddhist

/assign @k82cn

HalfBuddhist avatar Feb 07 '25 10:02 HalfBuddhist

PTAL @JesseStutler @Monokaix @lowang-bh

hwdef avatar Feb 08 '25 02:02 hwdef

/lgtm Thanks for your contribution.

BTW, It is best to compress the number of commits, 4 are too much. In addition, your commit email does not match the github email address.

Done in commit b4a2ff9a557c24083e8ddbe200d5b694d9bcfd6b @hwdef

HalfBuddhist avatar Feb 08 '25 07:02 HalfBuddhist

/lgtm

hwdef avatar Feb 08 '25 08:02 hwdef

/approve

Monokaix avatar Apr 17 '25 12:04 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Apr 17 '25 12:04 volcano-sh-bot