volcano
volcano copied to clipboard
volcano-sh
feat:adding sidecar
Welcome @7h3-3mp7y-m4n!
It looks like this is your first PR to volcano-sh/volcano.
Thank you, and welcome to Volcano. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
We should also add filter logic like https://github.com/kubernetes/kubernetes/blob/f8d5b2074c9b3a1629ef085b9e17a5370f393732/pkg/scheduler/framework/plugins/noderesources/fit.go#L217.
We should also add filter logic like https://github.com/kubernetes/kubernetes/blob/f8d5b2074c9b3a1629ef085b9e17a5370f393732/pkg/scheduler/framework/plugins/noderesources/fit.go#L217.
okay :)
Hi, since it's not active and we will release v1.10 soon so I fire a new PR based on your work and your commit is also inclueded, thanks for your contribution!
@7h3-3mp7y-m4n: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@lowang-bh: Closed this PR.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.