volcano-sh
Remove init variable in Reclaimable and Preemptable parts of session_plugins
Hello,
it's a really small - so called - refactor. I've just changed values of init variable which shows if this is the first iteration of Reclaimable/Preemptable. In my opinion this if:
if init {
victims = candidates
init = false
}
is more readable than:
if !init {
victims = candidates
init = true
}
It's like a double negation.
@lowang-bh @googs1025 I've pushed new commit with changes suggested by @googs1025 - as a reader I can say that it's pretty readable and I can understand a code flow.
Hello Guys,
Could You comment? If changes are too small and unimportant, just let me know, I will close this.
And thank You for the previous reaponses!
/assign @Monokaix
hi @Monokaix Maybe you can take a look and suggest an edit!
/assign @Monokaix hi @Monokaix Maybe you can take a look and suggest an edit!
I think it's ok: )
Thank You @Monokaix . And sorry for stupid question, but what should I do next?
Thank You @Monokaix . And sorry for stupid question, but what should I do next?
Just wait for other approver to be reviewed and merged. 👍
@hudson741 @k82cn @googs1025 Is there a chance to get review/something with this small change, or should I abandon it and close?
/assign @Monokaix
You can just keep your own commit and remove Merge Branch xxx to kepp a clean commit: )
Sorry, I was using a button in the PR UI to merge master branch, it's not the best idea. But now branch is rebased from master, my commit is on the tip.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Monokaix
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/scheduler/OWNERS~~ [Monokaix]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
