volcano icon indicating copy to clipboard operation
volcano copied to clipboard

delete reservation plugin doc

Open hwdef opened this issue 1 year ago • 4 comments

Reservation plugin has been deleted. This doc is no longer needed. It will confuse users. Additionally, I recommend cleaning up documents that have expired.

hwdef avatar Jun 27 '24 02:06 hwdef

/assign @Monokaix @lowang-bh

hwdef avatar Jun 27 '24 02:06 hwdef

have the problems mentioned in this doc been resolved? And I saw that https://github.com/volcano-sh/volcano/issues/748 mentioned that this feature is released, but I didn't see that.

Monokaix avatar Jun 27 '24 03:06 Monokaix

I think the reservation plugin has been deprecated and replaced by the SLA plugin. @Thor-wl Can you clarify?

hwdef avatar Jun 27 '24 03:06 hwdef

@Monokaix @googs1025 The docs has been updated. Please review again.

hwdef avatar Sep 03 '24 07:09 hwdef

/lgtm

googs1025 avatar Sep 03 '24 09:09 googs1025

/approve

Monokaix avatar Sep 04 '24 01:09 Monokaix

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar Sep 04 '24 01:09 volcano-sh-bot