volcano icon indicating copy to clipboard operation
volcano copied to clipboard

fix gpu memory allocation using `vgpu-memory-percentage`

Open abowloflrf opened this issue 1 year ago • 7 comments

fix #3465

uint(val.MemPercentagereq/100) could be 0. The memory result is always 0 when using percentage to allocate memory.

abowloflrf avatar May 13 '24 13:05 abowloflrf

Welcome @abowloflrf!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot avatar May 13 '24 13:05 volcano-sh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign thor-wl You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

volcano-sh-bot avatar May 13 '24 13:05 volcano-sh-bot

thanks for fixing that, we plan to test that function before officially release

archlitchi avatar May 14 '24 03:05 archlitchi

thanks for fixing that, we plan to test that function before officially release

ok, i'll also add some ut for this pr later

abowloflrf avatar May 14 '24 04:05 abowloflrf

thanks for fixing that, we plan to test that function before officially release

ok, i'll also add some ut for this pr later

ut added /cc @archlitchi

abowloflrf avatar May 14 '24 14:05 abowloflrf

@archlitchi Is this already supported?

Monokaix avatar Jul 31 '24 09:07 Monokaix

I've encountered this issue as well; why not merge this PR?

cybergeek2077 avatar Oct 09 '24 09:10 cybergeek2077

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Feb 01 '25 01:02 stale[bot]