fix gpu memory allocation using `vgpu-memory-percentage`
fix #3465
uint(val.MemPercentagereq/100) could be 0. The memory result is always 0 when using percentage to allocate memory.
Welcome @abowloflrf!
It looks like this is your first PR to volcano-sh/volcano.
Thank you, and welcome to Volcano. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
thanks for fixing that, we plan to test that function before officially release
thanks for fixing that, we plan to test that function before officially release
ok, i'll also add some ut for this pr later
thanks for fixing that, we plan to test that function before officially release
ok, i'll also add some ut for this pr later
ut added /cc @archlitchi
@archlitchi Is this already supported?
I've encountered this issue as well; why not merge this PR?
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.